Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use most_recent = true when using VPC CNI custom configuration #1447

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: Use most_recent = true when using VPC CNI custom configuration #1447

merged 1 commit into from
Feb 22, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Use most_recent = true when using VPC CNI custom configuration

Motivation

  • Without using the most recent, the default version of the VPC CNI pulled may or may not have support for the environment variable versions used. This ensures that the latest addon version is used which has access to all of the environment variables used in the examples

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner February 22, 2023 22:07
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 22, 2023 22:07 — with GitHub Actions Inactive
csantanapr
csantanapr approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@csantanapr csantanapr merged commit 57cacc0 into main Feb 22, 2023
@csantanapr csantanapr deleted the fix/use-recent-addon-versions branch February 22, 2023 22:21
dhoeld pushed a commit to dhoeld/terraform-aws-eks-blueprints that referenced this pull request Feb 24, 2023
@bryantbiggs
fix: Use most_recent = true when using VPC CNI custom configuration (…
30382a8 
…aws-ia#1447)
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
@bryantbiggs
fix: Use most_recent = true when using VPC CNI custom configuration (…
9f3493e 
…aws-ia#1447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @csantanapr