Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PULL_REQUEST_TEMPLATE.md #1433

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 requested a review from a team as a code owner February 13, 2023 22:50
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test February 13, 2023 22:50 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 changed the title Update PULL_REQUEST_TEMPLATE.md chore: Update PULL_REQUEST_TEMPLATE.md Feb 13, 2023
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test February 14, 2023 22:18 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 merged commit 9f30a58 into main Feb 14, 2023
@askulkarni2 askulkarni2 deleted the askulkarni2-patch-1 branch February 14, 2023 22:41
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants