Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional path variable for the platform_team_eks_access aws_iam_policy #1431

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

nadaj
Copy link
Contributor

@nadaj nadaj commented Feb 13, 2023

What does this PR do?

Adds an optional path variable for the platform_team_eks_access aws_iam_policy.

Motivation

Needed a custom path for the resource aws_iam_policy.platform_team_eks_access, since the roles used to deploy the resources have strict permissions on certain policy paths.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@nadaj nadaj requested a review from a team as a code owner February 13, 2023 13:58
@bryantbiggs
Copy link
Contributor

bryantbiggs commented Feb 13, 2023

do you have roles with paths (not "/" but something else) that access the cluster today? I think you will find issues with trying to connect to the cluster with roles with custom paths due to kubernetes-sigs/aws-iam-authenticator#268

@nadaj
Copy link
Contributor Author

nadaj commented Feb 14, 2023

I have paths that have a prefix in the policies e.g. arn:aws:iam::<account>:policy/<path_prefix><policy_name> and it is working in my case.

@bryantbiggs
Copy link
Contributor

ah, my apologies - I overlooked that this was for a policy and not for a role. This should be ok to add once you've resolved the CI checks

@nadaj nadaj temporarily deployed to EKS Blueprints Test February 14, 2023 14:33 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 78b796c into aws-ia:main Feb 14, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants