-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for EKS addon data version selection of most_recent
(true
/false
)
#1048
Conversation
…t` (`true`/`false`)
@@ -33,6 +31,8 @@ repos: | |||
- '--args=--only=terraform_required_providers' | |||
- '--args=--only=terraform_standard_module_structure' | |||
- '--args=--only=terraform_workspace_remote' | |||
- id: terraform_validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just moved lower in the checks since it takes the longest - the shortest checks will return first before the longer checks
module "eks_blueprints_kubernetes_addons" { | ||
# Essential inputs are not shown for brevity | ||
|
||
enable_amazon_eks_coredns = true | ||
amazon_eks_coredns_config = { | ||
addon_version = data.aws_eks_addon_version.default["coredns"].version | ||
resolve_conflicts = "OVERWRITE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing defaults and showing whats unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…t` (`true`/`false`) (aws-ia#1048)
What does this PR do?
most_recent
(true
/false
)resolve_conflicts
as"OVERWRITE"
as the defaultMotivation
More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes