fix: Helm-addon irsa_config default value for create_namespace condition #1019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With 4.12 the default value of the
irsa_config
variable was changed fromnull
to{}
while the value of thecreate_namespace
property within theresource "helm_release" "addon"
was not updated and remained as:The correct value should be:
Versions comparison: v4.11.0...v4.12.0#diff-08ec4987c7b396bd22851dba98a35f66754059cbc09e6f88a0801533f8d03946R33
Motivation
I was using v4.11.0, updated to v4.12.0, and spotted that the
create_namespace
value I wasn't overriding was suddenly changed from the defaulttrue
tofalse
.More
pre-commit run -a
with this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*
is required for new a new addonFor Moderators
Additional Notes
Got:
Instead of: