docs: Add doc notes regards tf v1.3 support #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zvikan
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
bryantbiggs
as code owners
bryantbiggs
reviewed
Sep 30, 2022
| @@ -105,6 +105,9 @@ If you are interested in contributing to EKS Blueprints, see the [Contribution g | |||
|
|
|||
| --- | |||
|
|
|||
| > **_NOTE:_** Use terraform versions after version 1.0.0 and before version 1.3.0. | |||
There was a problem hiding this comment.
terraform-docs will wipe this out (after CI checks complain)
There was a problem hiding this comment.
it's before the <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK --> , you sure?
There was a problem hiding this comment.
oh .... I'm not that smart, please ignore me 😬
|
Likely not needed after #1011 |
|
Using terraform 1.3 is still a problem we need to document for user, they can't use 1.3 cc @bryantbiggs |
|
don't know why the md lint is failing is just one line change |
|
its this 7abef5b we can ignore for now and once my PR lands it will be fixed |
|
ah like something got moved, and the current md is broken in main |
bryantbiggs
approved these changes
Oct 7, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Co-authored-by: Carlos Santana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes