Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowness #264

Closed
skuriyadi opened this issue Feb 16, 2022 · 4 comments
Closed

Slowness #264

skuriyadi opened this issue Feb 16, 2022 · 4 comments
Labels
question Further information is requested

Comments

@skuriyadi
Copy link

Is anyone facing slowness in applying the plan while using latest version?

Thank you

@skuriyadi skuriyadi added the question Further information is requested label Feb 16, 2022
@Zvikan
Copy link
Contributor

Zvikan commented Feb 16, 2022

Hey @skuriyadi !
Thank you for reporting this issue, we've hearing multiple reports recently and we already merged a fix to improves the terraform plan times, see #257, we've seen TF plan goes down to 30 seconds to 1 minute, compare to 5+ minutes before.

Can you please try using the latest version of main branch, and see if terraform plan times is back to normal?
If it's still taking longer than usual, can you please let us know the following:

  • Which example you are using ?
  • How long did TF plan take?
  • Which code branch/version are you using while testing?

We plan to release a new tag (AKA new release) soon, so it will be great to see if our latest changes helps with the slowness you are reporting.
Thank you!

@skuriyadi
Copy link
Author

skuriyadi commented Feb 16, 2022

Hey @Zvikan ,
I missed the PR #257, I upgraded to the latest version and now the planning is taking one minute to build which is expected as I am adding other resources in it. I am seeing below message but not breaking the plan.

Warning: Experimental feature "module_variable_optional_attrs" is active.

@Zvikan
Copy link
Contributor

Zvikan commented Feb 16, 2022

@skuriyadi Thank you for the quick reply, happy to read the plan is back to normal.
As for the module_variable_optional_attrs - it was added in #223

@askulkarni2
Copy link
Contributor

@skuriyadi we use module_variable_optional_attrs for defaults so we can use input variables type constraints.

Looks like the performance issue you reported as been resolved. I will close this for now.

alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this issue Mar 25, 2023
chore: Better use of environment variables for ADOT collectors, consistent directory names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants