Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for image_pull_secrets on service account #11

Merged
merged 1 commit into from
May 17, 2023
Merged

feat: Add support for image_pull_secrets on service account #11

merged 1 commit into from
May 17, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add support for image_pull_secrets on service account

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner May 17, 2023 12:01
askulkarni2
askulkarni2 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@askulkarni2 askulkarni2 merged commit afc511c into main May 17, 2023
@askulkarni2 askulkarni2 deleted the feat/image-pull-secrets branch May 17, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting image_pull_secret for service accounts
2 participants
@bryantbiggs @askulkarni2