feat: pipe system logs to nucleus log path #1661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Sep 13, 2024
| @@ -64,6 +65,7 @@ public class KernelAlternatives { | |||
| private static final String KERNEL_LIB_DIR = "lib"; | |||
| private static final String LOADER_PID_FILE = "loader.pid"; | |||
| static final String LAUNCH_PARAMS_FILE = "launch.params"; | |||
| public static final String LOGS_DIR = "logs"; | |||
There was a problem hiding this comment.
should read the Greengrass log directory, since the customer can configure it, right?
There was a problem hiding this comment.
Yep, thats right, gonna make that change now
MikeDombo
reviewed
Sep 13, 2024
| @@ -24,9 +27,10 @@ public class NucleusPaths { | |||
| private Path kernelAltsPath; | |||
| private Path cliIpcInfoPath; | |||
| private Path binPath; | |||
| private Path logsPath; | |||
There was a problem hiding this comment.
we own the logger, the logger has methods to read the path it is going to write to already.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/com/aws/greengrass/util/orchestration/SystemServiceUtils.java
Dismissed
Show dismissed
Hide dismissed
alter-mage
force-pushed
the
loader-log
branch
2 times, most recently
from
1e509ed
to
66a6f99
Compare
alter-mage
force-pushed
the
loader-log
branch
4 times, most recently
from
5f1515e
to
da6fefc
Compare
|
Binary incompatibility detected for commit 499419f. com.aws.greengrass.util.NucleusPaths is binary incompatible and is source incompatible because of CONSTRUCTOR_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 499419f |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 499419f |
yitingb
previously approved these changes
Oct 1, 2024
|
Why do we log into |
junfuchen99
reviewed
Oct 3, 2024
|
|
||
| import java.util.Scanner; | ||
|
|
||
| public final class NucleusLogsSummarizer { |
There was a problem hiding this comment.
What about Windows log? They already exist and we just need to parse them
There was a problem hiding this comment.
Updated with windows logging as well
alter-mage
force-pushed
the
loader-log
branch
5 times, most recently
from
2c331ca
to
6a82f80
Compare
alter-mage
force-pushed
the
loader-log
branch
from
6a82f80
to
08aaf77
Compare
alter-mage
force-pushed
the
loader-log
branch
from
08aaf77
to
499419f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This modifies the loader script to dump its shell logs into
aws.greengrass.Nucleus.logfile. Nucleus reads this log file and summarizes loader logs as part of the deployment status FSS message in case a deployment finishes with a Nucleus Restart Failure. Nucleus also cleans up this log file while preparing for bootstrap to ensure a fresh set of loader logs for each bootstrap deployment.Why is this change necessary:
Currently, we do not have any mechanism to understand deployment failures due to NRF except chasing customers for loader logs. With this change, a summarized version of loader logs will be published to FSS which we can use to debug NRF failures further.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.