Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency graph clipping (#33) #34

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

massi-ang
Copy link
Contributor

@massi-ang massi-ang commented Sep 15, 2023

Issue #, if available:
Fixes #33

Description of changes:
Set the width of the dependency graph SVG component to 100% of the parent container.
Upgraded node to v18

Why is this change necessary:
The existing code was clipping the diagram to the right in certain situations

How was this change tested:
Visually by a human

image

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Set the width to 100% of the parent container.
Upgraded node to v18
Copy link
Member

@MikeDombo MikeDombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this!

If you wouldn't mind too much, could you add a screenshot of the fixed graph in the description of the PR?

@MikeDombo MikeDombo merged commit 02ff551 into aws-greengrass:main Sep 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(LocalDebugConsole): component diagram cut to the right
2 participants