Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(job_attachments): remove hard-coded endpoint #73

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

gahyusuh
Copy link
Contributor

@gahyusuh gahyusuh commented Oct 13, 2023

What was the problem/requirement? (What/Why)

The Job Attachments module contains a hard-coded service endpoint constant that is currently not being used anywhere in the codebase. Also, defining such endpoint within the module (or library) seems incorrect.

What was the solution? (How)

Removed the hard-coded service endpoint from the Job Attachments module

What is the impact of this change?

It's a minor clean-up. This removal has no impact on the existing functionality as the constant was not in use.

How was this change tested?

  • Ran hatch run lint && hatch run test and made sure that all unit tests passed.
  • Performed an end-to-end test in the Beta environment by submitting a job through CLI --> processing it with a worker agent (CMF) to ensure there are no issues during the process.

Was this change documented?

No.

Is this a breaking change?

No.

@gahyusuh gahyusuh requested a review from a team as a code owner October 13, 2023 16:31
@gahyusuh gahyusuh merged commit 273527f into mainline Oct 13, 2023
@gahyusuh gahyusuh deleted the gahyusuh/remove_endpoint_in_ja branch October 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants