-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump click from 8.1.3 to 8.1.7 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
labels
Aug 24, 2023
ttblanchard
pushed a commit
that referenced
this pull request
Aug 25, 2023
…and 'profile' override in bealine:// (#7) * feat: Add profile override support to the bealine:// protocol The 'profile picker' in the downloader looks at the Bealine config and matches the first profile(in the order they are in .bealine/config) that has that farm as default. This is not-precise. I saw some cases where a user had multiple profiles, but only the second one was valid. This is not likely to happen with 'real' customers, but is completely a non-obvious behavior to anyone. With this change, Cloud Companion(when its used) and set this profile name, ensuring the downloader is using the same profile as Cloud Companion. Of course, longer term we hope to put this downloader right into Cloud Companion, but for now seems worthwhile. Testing: - Added a unit test to validate the profile is overriden as expected * feat!: Add CloudCompanion support for Login/Logout BREAKING CHANGE: api.login and api.logout signatures have changed slightly 1. The return value of api.Login has changed. Itaswere and still is a string, but instead of assuming it's a SSO start URL it is now a more complete message for the user. Users no longer have to frame as 'SSO Start URL {return_value}' but use the value as the message 2. onPendingAuthorization now only uses kwargs. This is because SSO/CloudCompanion login types provide different information. The Login/Logout button now understand both Permission Sets and CloudCompanion. Cloud Companion will now 'owns' a section in .bealine/config, [cloud-companion]. It will write a key 'path' that is the path to its executable when it is used. Bealine already assumes that any AWS profile with the 'studio_id' key is managed by Cloud Companion. If the user attempts to 'login' then we use that path from the config and invoke CloudCompanion with a known set of args(login --profile {profileName}). We then wait for the credentials to become valid. Logout works similarly CloudCompanion has a corresponding change to add these login/logout commands. When 'login' is used, CloudCompanion pops up and logs into that profile. Once it logs in, it shows a dialog telling the user it will minimize which will then bring BeaLine back into focus There's a slight change to the return values of api.login/api.logout. Testing: * Only tested on mac so far. I will test on windows during PR review * I tested login/logout through the dev GUI for both a permissionset and Cloud Companion * New unit tests added and some updated * login/logout also work via the CLI
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
August 28, 2023 00:49
ec632be
to
d812543
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
August 29, 2023 21:06
d812543
to
15aaf7f
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 7, 2023 22:06
15aaf7f
to
a150003
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 11, 2023 18:49
a150003
to
dc10ab9
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 11, 2023 19:13
dc10ab9
to
c737b3a
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 11, 2023 19:58
c737b3a
to
3d3ccad
Compare
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 14, 2023 17:43
3d3ccad
to
a981b81
Compare
Bumps [click](https://github.com/pallets/click) from 8.1.3 to 8.1.7. - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst) - [Commits](pallets/click@8.1.3...8.1.7) --- updated-dependencies: - dependency-name: click dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/pip/click-8.1.7
branch
from
September 22, 2023 15:49
a981b81
to
a144698
Compare
@dependabot close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps click from 8.1.3 to 8.1.7.
Release notes
Sourced from click's releases.
Changelog
Sourced from click's changelog.
... (truncated)
Commits
874ca2b
release version 8.1.76e1f6d3
completion(fish): add back ; as line endings in fish script (#2570)a955c77
update fish enabling script3c1529e
add back semicolons in fish scripta260ca6
Replace bash shell completion version error with warning (#2576)d9db70c
bash version support shows warning instead of error22b9b1c
Fix incorrect passing of flags to re.sub (#2581)d69d210
fix flake8 findingaf2da1e
Fix incorrect passing of flags to re.subbb6a872
start version 8.1.7You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)