Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job-attachments): Update example scripts in deadline-cloud/examples #58

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

gahyusuh
Copy link
Contributor

@gahyusuh gahyusuh commented Sep 26, 2023

What was the problem/requirement? (What/Why)

In the last few months, a lot of changes have been made to our backend services, but our examples scripts in deadline-cloud/examples, which are for manual testing for the Job Attachments library, has not been updated accordingly.

What was the solution? (How)

The example scripts are updated to ensure they function properly with these recent backend changes.

What is the impact of this change?

We can use those example scripts to do some manual upload/download tests.

How was this change tested?

  • Ran unit tests: hatch run lint && hatch run test
  • Ran integration tests: hatch run integ:test
  • Ran each script individually, and confirmed that they all ran without any issues.

Was this change documented?

No.

Is this a breaking change?

No.

@gahyusuh gahyusuh requested a review from a team as a code owner September 26, 2023 18:00
@gahyusuh gahyusuh force-pushed the gahyusuh/fix_sample_scripts branch from d74389e to 6a3310f Compare September 26, 2023 18:10
Copy link
Contributor

@marofke marofke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up!

@gahyusuh gahyusuh merged commit cd95313 into mainline Sep 26, 2023
@gahyusuh gahyusuh deleted the gahyusuh/fix_sample_scripts branch September 26, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants