fix: Custom Host Requirements ui now accepts decimals. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erico-aws
force-pushed
the
add_dec_to_SpinBox
branch
3 times, most recently
from
541a79f to
8bb1a04
Compare
miabatta
previously approved these changes
Dec 2, 2024
leongdl
previously approved these changes
Dec 5, 2024
|
Nit; please add a screenshot to the PR description next time? |
erico-aws
force-pushed
the
add_dec_to_SpinBox
branch
from
90f9bd5 to
f7c0f2d
Compare
miabatta
previously approved these changes
Dec 18, 2024
epmog
requested changes
Dec 19, 2024
Signed-off-by: Eric Osiowy <[email protected]>
erico-aws
force-pushed
the
add_dec_to_SpinBox
branch
from
6824a29 to
7dfedd7
Compare
miabatta
approved these changes
Jan 9, 2025
|
epmog
approved these changes
Jan 9, 2025
epmog
reviewed
Jan 9, 2025
Comment on lines
+951
to
+952
| min: int = MIN_INT_VALUE, | ||
| max: int = MAX_INT_VALUE, |
There was a problem hiding this comment.
Should the double spin box have ints for the min/max? Does openjd specify what they do and if they should be float min/max?
There was a problem hiding this comment.
min needs to be 0 (non-negative). Max could be float max.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Bug: Fleet Worker Requirements lets values to be set in AWS console that cannot be set in the submitter UI
What was the problem/requirement? (What/Why)
Through the command line, Custom Host Requirements allow for decimal values. Through the UI it wasn't possible to enter a decimal value.
What was the solution? (How)
Switched the
OptionalSpinBoxcontrol to inherit fromQDoubleSpinBox. It also defaults to allowing values with 2 decimal places.The hardware requirements use the same OptionalSpinBox control. They don't need decimals so I set them to have 0 decimal places.
I also checked the OpenJD spec to make sure that host requirements could have floating point values.
What is the impact of this change?
The submitters that use this UI (like Blender) will behave more like their cli counterparts.
How was this change tested?
Built locally and installed into the Blender submitter. Opened Blender and submitted Jobs with Host Requirements with the integrated submitter.
Was this change documented?
No.
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.