fix: use description from GUI submitter #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-wong-aws
force-pushed
the
fix_description
branch
from
d435460 to
8b84e61
Compare
mwiebe
approved these changes
Nov 26, 2024
jericht
approved these changes
Nov 28, 2024
Signed-off-by: Joel Wong <[email protected]>
joel-wong-aws
force-pushed
the
fix_description
branch
from
8b84e61 to
55feed6
Compare
|
Merged
YutongLi291
pushed a commit
to YutongLi291/deadline-cloud-fork
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Joel Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The description from the AWS Deadline Cloud GUI was not being submitted to the service via the Deadline GUI
What was the solution? (How)
The description field was not being captured and passed correctly to the service. Updated the relevant code.
What is the impact of this change?
Description field now works as expected.
How was this change tested?
Ran
hatch shell, thendeadline bundle gui-submit sample_joband input a description, then input no description to the GUI. The resulting job template had a description (or did not have a description), as expected.Was this change documented?
No, N/A
Does this PR introduce new dependencies?
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.