feat: Add a simple backoff and retry utility helper #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leongdl
force-pushed
the
retry
branch
2 times, most recently
from
cd3c3a8 to
84763d2
Compare
crowecawcaw
reviewed
Sep 25, 2024
Comment on lines
108
to
110
| tries: int = 4, | ||
| delay: Union[int, float, Tuple[Union[int, float], Union[int, float]]] = 3.0, | ||
| backoff: float = 2.0, |
There was a problem hiding this comment.
Nit: these defaults would lead to very slow failure in the worst case. Would it make sense to tighten them up?
There was a problem hiding this comment.
Sure, I can adjust them in a follow up (i have many PRs on going)
how about 1 retry, delay of 1s, back off 1s?
crowecawcaw
previously approved these changes
Sep 25, 2024
crowecawcaw
approved these changes
Sep 26, 2024
jericht
approved these changes
Sep 26, 2024
Signed-off-by: David Leong <[email protected]>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
What was the solution? (How)
What is the impact of this change?
How was this change tested?
hatch build
hatch run all:lint
hatch run fmt
hatch run test
Have you run the unit tests?
Yes
Have you run the integration tests?
Not applicable.
Have you made changes to the
downloadorasset_syncmodules? If so, then it is highly recommendedthat you ensure that the docker-based unit tests pass.
Not applicable
Was this change documented?
Not applicable. New internal API function docs added.
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.