test: add integ tests to test download func #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Tran <[email protected]>
|
crowecawcaw
approved these changes
Jul 29, 2024
YutongLi291
approved these changes
Jul 29, 2024
| def test_download_outputs_no_outputs_dir( | ||
| job_attachment_test: JobAttachmentTest, | ||
| sync_outputs: SyncOutputsOutput, | ||
| ): |
There was a problem hiding this comment.
nit: We should add typing for this return
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Aug 26, 2024
Signed-off-by: Alex Tran <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Integ test did not cover all test cases that we wanted
What was the solution? (How)
Add more integ test to improve coverage.
What is the impact of this change?
We can now test if download with no output dir have the correct behavior
We can now test if long file path on Windows with UNC notation will not raise exception
How was this change tested?
hatch run testhatch run integ:testWas this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.