fix: Remove delay after hitting Submit button #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteban Papp <[email protected]>
mwiebe
approved these changes
Sep 15, 2023
justinsaws
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
After hitting the "Submit" button, there are AWS API calls that may take some time. In my case, I was observing ~5s after hitting the "Submit" button on Windows/Nuke before the submission dialog popped up.
What was the solution? (How)
Small change to initialize the dialog and show it before starting the submission.
What is the impact of this change?
Users will get a quicker feedback after hitting the Submit button.
How was this change tested?
Manually.
Was this change documented?
No
Is this a breaking change?
No