fix: Add file path limit log #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Tran <[email protected]>
Signed-off-by: Alex Tran <[email protected]>
Signed-off-by: Alex Tran <[email protected]>
Signed-off-by: Alex Tran <[email protected]>
…line-cloud-fork into add-file-path-limit-log
…line-cloud-fork into add-file-path-limit-log
…line-cloud-fork into add-file-path-limit-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
If we have file path that is longer than 260 chars on Windows, JA will throw an error of file not found which is not necessary correct and do not bring any value to track down the problem
What was the solution? (How)
Add comparison of file path and if longer than 260 chars, we will throw a more meaningful error message
What is the impact of this change?
We have more meaningful logs so it's easier to detect what when wrong
How was this change tested?
Run all unit + integ tests
Manually run download job output test on Linux and Windows
Manually run Asset sync on Linux and Windows CMF
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.