test: run integration tests every four hours #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <[email protected]>
leongdl
approved these changes
Jul 4, 2024
leongdl
reviewed
Jul 4, 2024
| @@ -1,6 +1,8 @@ | |||
| name: Mainline Merge Integration Tests | |||
|
|
|||
| on: | |||
| schedule: | |||
| - cron: '0 */4 * * *' | |||
There was a problem hiding this comment.
Chatted offline,
Why 4 ? Because worker agent side is running every 4 hours too.
leongdl
approved these changes
Jul 4, 2024
godobyte
approved these changes
Jul 4, 2024
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Yutong Li <[email protected]> Signed-off-by: Cloud User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
To better the repo's code quality, we should run the integration tests on a scheduled basis, to prevent flakiness, issues with dependencies, etc.
What was the solution? (How)
Every 4 hours, the integration tests will be ran as an action workflow in mainline.
What is the impact of this change?
Better repo quality and guarantee that the main functionality is tested.
How was this change tested?
hatch build. Verified that the syntax was correct.Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.