Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: revert json output and schema version #374

Merged

Conversation

epmog
Copy link
Contributor

@epmog epmog commented Jun 26, 2024

Resolves #376

What was the problem/requirement? (What/Why)

  1. Integrated submitters failed on submit with:
'RenderSubmitterUISettings' object has no attribute 'parameters'

image

  1. jsonschema was updated to a version that required additional code changes

What was the solution? (How)

Revert the two commits that introduced issues

What is the impact of this change?

integrated submitters work, and we can build submitter installers again

How was this change tested?

Deployed the new version with Maya and confirmed that we no longer get this error

Was this change documented?

N/A

Is this a breaking change?

Yes - we're removing a CLI option that was added that may have worked for users until we get the proper fix in.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@epmog epmog requested a review from a team as a code owner June 26, 2024 00:52
@epmog epmog force-pushed the revert_json_output_and_schema_version branch from c53c6fa to 6675ea3 Compare June 26, 2024 00:56
@epmog epmog changed the title fix!: json output and schema version fix!: revert json output and schema version Jun 26, 2024
@epmog epmog marked this pull request as draft June 26, 2024 01:43
@moorec-aws moorec-aws marked this pull request as ready for review June 26, 2024 14:50
@moorec-aws moorec-aws marked this pull request as draft June 26, 2024 14:59
@epmog epmog changed the title fix!: revert json output and schema version revert: revert json output and schema version Jun 26, 2024
@moorec-aws moorec-aws force-pushed the revert_json_output_and_schema_version branch from 6675ea3 to 672e140 Compare June 26, 2024 19:17
@epmog epmog marked this pull request as ready for review June 26, 2024 19:17
@moorec-aws moorec-aws merged commit 9995aad into aws-deadline:mainline Jun 26, 2024
15 checks passed
@epmog epmog deleted the revert_json_output_and_schema_version branch June 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Integrated submitters using deadline 0.48.5 cannot submit jobs
3 participants