-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(job_attachments): handle case-insensitive path extraction on Windows #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loachri
reviewed
Apr 6, 2024
mwiebe
reviewed
Apr 6, 2024
ttblanchard
reviewed
Apr 6, 2024
gahyusuh
force-pushed
the
gahyusuh/win_case_insensitive
branch
3 times, most recently
from
April 7, 2024 00:51
af21e7d
to
d857b1a
Compare
loachri
previously approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ship it
ttblanchard
previously approved these changes
Apr 7, 2024
gahyusuh
force-pushed
the
gahyusuh/win_case_insensitive
branch
from
April 7, 2024 01:27
d857b1a
to
3a91918
Compare
loachri
previously approved these changes
Apr 7, 2024
gahyusuh
force-pushed
the
gahyusuh/win_case_insensitive
branch
3 times, most recently
from
April 7, 2024 02:19
930d69f
to
daf9c7c
Compare
Signed-off-by: Gahyun Suh <[email protected]>
gahyusuh
force-pushed
the
gahyusuh/win_case_insensitive
branch
from
April 7, 2024 02:31
daf9c7c
to
c2d70c1
Compare
mwiebe
approved these changes
Apr 7, 2024
loachri
approved these changes
Apr 7, 2024
ttblanchard
approved these changes
Apr 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
On Windows, asset paths are not treated as case-insensitive, leading to incorrect grouping of assets with paths that differ only in case. For example, if two paths "C:\Username\user\test1.txt" and "c:\uSerNaMe\user\test2.txt" exist, their shared root path should be extracted as "C:\Username\user". However, currently, these paths are treated as having different root paths due to the case-sensitivity issue.
What was the solution? (How)
The
_get_asset_groups
function has been modified to ensure that the root path extraction is case-insensitive on Windows.What is the impact of this change?
Resolves the issue of incorrect asset grouping on Windows due to case-sensitivity
How was this change tested?
Where the actual input directory's name on the file system is
inputs_1
. The job submission and job execution on a worker was working, and generated output files as expected.Was this change documented?
No.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.