fix(job_attachments): pass original exception to AssetSyncError #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
approved these changes
Apr 3, 2024
Signed-off-by: Gahyun Suh <[email protected]>
gahyusuh
force-pushed
the
gahyusuh/fix_exception_wrapping
branch
from
d60f1ba to
d912a00
Compare
lucaseck
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In certain cases, when raising
AssetSyncErrorfrom another exception usingthe error message was not being displayed correctly. This makes it hard to debug and identify the root cause of the issue.
What was the solution? (How)
Change
raise AssetSyncError from etoraise AssetSyncError(e) from e, passing the original exception instanceeto theAssetSyncError, so that we can ensure that the error message is preserved and displayed correctly.What is the impact of this change?
Improves the overall debugging experience and make it easier to understand the root cause of issues.
How was this change tested?
hatch run testhatch run integ:test[WinError 183] Cannot create a file when that file already existserror occurred when running the output download command,deadline job download-output < resource ids > --output json --conflict-resolution CREATE_COPY, on windows. Before this change, the download would fail silently without any error message. After the change, the error message was correctly displayed.Was this change documented?
No.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.