ci: remove formatting check for python 3.7 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
force-pushed
the
moorec/black-3.7
branch
7 times, most recently
from
fa0f38b to
5290abd
Compare
ddneilson
previously approved these changes
Apr 1, 2024
moorec-aws
force-pushed
the
moorec/black-3.7
branch
2 times, most recently
from
5d44567 to
4d99414
Compare
ddneilson
approved these changes
Apr 1, 2024
epmog
approved these changes
Apr 1, 2024
evanspearman-a
approved these changes
Apr 1, 2024
Signed-off-by: Charles Moore <[email protected]>
ddneilson
force-pushed
the
moorec/black-3.7
branch
from
4d99414 to
983ed93
Compare
jusiskin
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
black 23.* is a security risk. Bumping to 24 and skipping the formatting check for 3.7
What was the solution? (How)
update black dep for 3.8+, and remove 23.*. Skip linting for python 3.7 unit tests.
What is the impact of this change?
no longer running linting on 3.7, resolved a security finding:
https://github.com/casillas2/deadline-cloud/security/dependabot/1
How was this change tested?
Was this change documented?
yes
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.