fix: include python3.dll in windows pyinstaller builds #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Windows pyinstaller builds were not able to pip install pyside6 after the fact. This was due to Shiboken failing to load it's dependent modules:
Unfortunately it doesn't tell us the missing DLL!
What was the solution? (How)
Long story short, found out that python3.dll was the missing link! So we force that include for Windows pyinstaller builds by checking the binaries and adding it if it isn't there.
What is the impact of this change?
Windows users of pyinstaller can now download pyside/qt!
How was this change tested?
On a windows instance:
Was this change documented?
n/a
Is this a breaking change?
n/a