fix: Removing overridden AWS_CONFIG_FILE path and base environment variabl…

[baxeaz]

What was the problem/requirement? (What/Why)

AWS_CONFIG_FILE was overridden in vfs.py's launch environment to be the "default" config file rather than the session created config file which we want to provide the VFS.

We were passing through the base os.environ variables unnecessarily, potentially exposing things we don't intend to even though the VFS is a trusted process we own.

Using POpen with sudo requires the -E option to properly persist the environment variables we pass through to the launched process.

What was the solution? (How)

Removing overridden AWS_CONFIG_FILE and base environment variables.

Launch VFS with -E option when using sudo -u to run as job-user

What is the impact of this change?

VFS should properly pick up provided credentials through installed config file's credential_process setting.

How was this change tested?

New tests added, all unit tests pass. Reenabled BealineWorkerImageTesting tests, ran with new deadline-cloud, all tests pass.

Was this change documented?

No

Is this a breaking change?

No

[ddneilson]

Great! This looks good to me. We're explicitly passing the env var dictionary to Popen so there's not a risk of leaking env vars from this process into the VFS process.