fix(job_attachment)!: remove os_group
field from Windows filesystem permission settings
#215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The
os_group
field in theWindowsFileSystemPermissionSettings
was identified as unnecessary and marked for removal to simplify the interface.What was the solution? (How)
To keep backward compatibility, we planned 3-phase removal:
os_group
when creatingWindowsFileSystemPermissionSettings
object. (PR: chore(deps): upgrade to openjd-sessions 0.7.* and deadline 0.40.* deadline-cloud-worker-agent#213)Steps 1 and 2 had been done. This PR is for Step 3.
Also, removed the
PosixFileSystemPermissionSettings
in themodels.py
. This whole class was moved toos_file_permissions.py
, and we already fixed worker agent to import PosixFileSystemPermissionSettings from os_file_permission. (PR: aws-deadline/deadline-cloud-worker-agent#81)What is the impact of this change?
We simplify the interface.
How was this change tested?
hatch run lint && hatch run test
hatch run integ:test
PosixFileSystemPermissionSettings
in themodels.py
does not break anything, and job submission & worker's input syncing are working as usual.Was this change documented?
Is this a breaking change?
This is breaking change for any package that still uses the
os_group
field in theWindowsFileSystemPermissionSettings
class. The only place is was being used was deadline-cloud-worker-agent, and we have already done the Step 2 to remove that usage.