chore(job_attachments): remove service model file #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
This package previously had a copy of the service model file (JSON) for use in these unit tests and by GitHub Checks to access the boto3 deadline client's stubber fixture. The service model file was at data/boto_module/deadline/1989-09-22/service.json. This setup seemed unnecessary for several reasons:
get_queue()
in (_aws/deadline.py) has already been covered multiple times in integration tests, so it seemed unnecessary to test it in unit tests by patching the service model file directly.What was the solution? (How)
What is the impact of this change?
Remove unnecessary dependencies and potential points of failure due to out-of-date service model.
How was this change tested?
Confirmed that all unit tests and integration tests (for job attachments) were passing.
Was this change documented?
No.
Is this a breaking change?
No.