feat: Create a CLI command to output a job schedule trace #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
force-pushed
the
markw/tracing-output
branch
7 times, most recently
from
c0bd6de to
a586f96
Compare
mwiebe
force-pushed
the
markw/tracing-output
branch
from
a586f96 to
c8add2f
Compare
agerveshi
approved these changes
Nov 13, 2023
mwiebe
force-pushed
the
markw/tracing-output
branch
5 times, most recently
from
116a0ca to
ba950b6
Compare
jusiskin
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Just one small possible typo in an error message.
Another concern is not having tests for the trace file generation, but I see we have a comment about that being a large effort and the “EXPERIMENTAL” warning is mentioned in the command-line help so that it’s clear this is not fully supported. On that basis, I'm okay with the change.
* While at it, added the --priority, --max-failed-tasks-count, and --max-retries-per-task options to `deadline bundle submit` * Add a really simple test of the new command Signed-off-by: Mark Wiebe <[email protected]> Signed-off-by: Mark Wiebe <[email protected]>
mwiebe
force-pushed
the
markw/tracing-output
branch
from
ba950b6 to
1dabf26
Compare
jusiskin
approved these changes
Dec 19, 2023
epmog
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Understanding the behavior of the Deadline Cloud scheduler is important to help guide its development and to help customers understand how effectively it is working on their behalf. Something that could visualize the entire schedule produced for a job would help.
What was the solution? (How)
deadline bundle submitWhat is the impact of this change?
Using this tool, we can evaluate how well the scheduler is working.
How was this change tested?
Ran it on some jobs, inspected the output.
Was this change documented?
Yes, it's in the CLI help. I marked it as EXPERIMENTAL, as we'll likely want to modify this over time.
Is this a breaking change?
No