fix(cli): download-output command handles UNC paths #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The
download-output
CLI command failed to download job outputs with UNC root paths, resulting in error that looks like below.The current logic for checking if a path format is Posix or Windows cannot handle UNC path format. It is just doing a naive string check on the root paths.
What was the solution? (How)
rootPathFormat
property in job'smanifests
(the value is either "windows" or "posix") to determine the submitting OS of the job.What is the impact of this change?
The download-output command can now support jobs with UNC root paths.
How was this change tested?
Was this change documented?
No.
Is this a breaking change?
No.