fix(job_attachments): include file path in error message for upload failures #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Previously, when multipart upload failed, the custom error message (in the
JobAttachmentsS3ClientError
) did not provide an info of which file had failed to upload. This lack of detail made debugging more difficult.What was the solution? (How)
This PR has the following changes:
test_download.py
to have correct indentation, ensuring that the assertions for verifying error messages are properly executed.What is the impact of this change?
Provide clearer context for debugging, helping users to identify the file in question and address issues with file uploads.
How was this change tested?
test_upload_file_to_s3_upload_part_failure
to verify that the error message includes the file path during a failed upload.hatch run test
, ensuring that the corrected unit tests are properly executed and all tests successfully passed.Was this change documented?
No.
Is this a breaking change?
No.