Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix telemetry endpoint with 'management.' #119

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

gahyusuh
Copy link
Contributor

@gahyusuh gahyusuh commented Nov 23, 2023

What was the problem/requirement? (What/Why)

From the client submitter, we used to send client telemetry requests (code here) to the service endpoint. I found that request.urlopen(req) is failing with below error.

<urlopen error [Errno -2] Name or service not known>

What was the solution? (How)

The endpoint that we were using was incorrect. It should be prefixed with management..

What is the impact of this change?

We can now send the client telemetry requests.

How was this change tested?

  • Ran unit tests and made sure all tests passed.
  • Manually tested by submitting jobs using the CLI against Alpha, Beta, and Prod endpoints. Confirmed that the client telemetry events were correctly recorded for each of those stage.

Was this change documented?

No.

Is this a breaking change?

No.

@gahyusuh gahyusuh marked this pull request as ready for review November 24, 2023 01:26
@gahyusuh gahyusuh requested a review from a team as a code owner November 24, 2023 01:26
@gahyusuh gahyusuh force-pushed the gahyusuh/fix_telemetry_endpoint branch from 0dbdca0 to 488e8dc Compare November 24, 2023 02:04
@gahyusuh gahyusuh force-pushed the gahyusuh/fix_telemetry_endpoint branch from 488e8dc to f46f695 Compare November 24, 2023 02:05
@gahyusuh gahyusuh merged commit fdbbe09 into mainline Nov 24, 2023
17 checks passed
@gahyusuh gahyusuh deleted the gahyusuh/fix_telemetry_endpoint branch November 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants