fix: Adding os_user to FileSystemPermissionSettings for use in the deadline vfs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amzn-mike
force-pushed
the
natmatn/vfs_os_user
branch
from
a3663c8 to
8906b1a
Compare
gahyusuh
approved these changes
Nov 16, 2023
amzn-mike
force-pushed
the
natmatn/vfs_os_user
branch
from
32dbbde to
80340e5
Compare
…adline VFS Signed-off-by: Nathan Matthews <[email protected]>
Signed-off-by: amzn-mike <[email protected]>
amzn-mike
force-pushed
the
natmatn/vfs_os_user
branch
from
80340e5 to
c9993e3
Compare
ddneilson
approved these changes
Nov 20, 2023
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
…adline vfs (#94) * fix: Adding os_user to FileSystemPermissionSettings for use in the deadline VFS Signed-off-by: Nathan Matthews <[email protected]> * fix: pass in missing os_env_vars variable Signed-off-by: amzn-mike <[email protected]> --------- Signed-off-by: Nathan Matthews <[email protected]> Signed-off-by: amzn-mike <[email protected]> Co-authored-by: amzn-mike <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
…adline vfs (#94) * fix: Adding os_user to FileSystemPermissionSettings for use in the deadline VFS Signed-off-by: Nathan Matthews <[email protected]> * fix: pass in missing os_env_vars variable Signed-off-by: amzn-mike <[email protected]> --------- Signed-off-by: Nathan Matthews <[email protected]> Signed-off-by: amzn-mike <[email protected]> Co-authored-by: amzn-mike <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: client-software-ci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The deadline VFS is unable to locate the credentials for the job-user when syncing inputs.
What was the solution? (How)
Pass the os_user as part of the FileSystemPermissionSettings object for use rebuilding the path to the AWS config file for the user running the render job. This along with the queueId will be used to reconstruct the Config path and profile name before mounting the VFS.
What is the impact of this change?
This will fix the deadline VFS so jobs marked with
VIRTUALfile system will succeed.How was this change tested?
Was this change documented?
No
Is this a breaking change?
No, as long as my deadline-cloud PR is merged in first