test: make credentials tests more robust to wait for job to start #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
requested changes
Dec 2, 2024
Signed-off-by: Li <[email protected]> Signed-off-by: Li <[email protected]>
|
jusiskin
approved these changes
Dec 3, 2024
jericht
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The credentials tests were not waiting properly for the job to start, causing them to be flaky sometimes.
This was because we are only checking for the lifecycle status, not the task run status.
What was the solution? (How)
Check that the taskRunStatus of the job is
RUNNINGorSUCCEEDEDto makes sure that the job has started.What is the impact of this change?
The tests will be less flaky
How was this change tested?
source .e2e_linux_infra.sh hatch run e2e-testNo windows test changes
Was this change documented?
N0
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.