test: add test for worker that requires no instance profile #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li <[email protected]>
YutongLi291
changed the title
Signed-off-by: Li <[email protected]>
YutongLi291
force-pushed
the
no_instance_profile
branch
from
f836bdd to
1039e9c
Compare
AlexTranAmz
approved these changes
Nov 19, 2024
|
jericht
approved these changes
Nov 19, 2024
YutongLi291
added a commit
to YutongLi291/deadline-cloud-worker-agent-fork
that referenced
this pull request
Nov 20, 2024
…line#481) * test: add test for worker that requires no instance profile Signed-off-by: Li <[email protected]>
godobyte
reviewed
Nov 25, 2024
| function_worker_factory( | ||
| dataclasses.replace( | ||
| worker_config, | ||
| disallow_instance_profile="True", |
There was a problem hiding this comment.
Is it expected to cause lint error?
test/e2e/test_worker_config.py:33: error: Unexpected keyword argument
"disallow_instance_profile" for "replace" of "DeadlineWorkerConfiguration" [call-arg]
dataclasses.replace(
^
Found 1 error in 1 file (checked 145 source files)
There was a problem hiding this comment.
I see it's due to an dependent change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The worker agent is able to be installed with the option
disallow-instance-profile, in which case if the worker instance is booted with an instance profile, the worker agent will shut itself down and not run jobs.We should verify that this functionality works as expected and that there are no regressions
What was the solution? (How)
Add a test to verify that the worker will not pick up any jobs in the case that the worker is configured to not have instance profiles, but the instance has a profile anyway.
Also upgraded test-fixtures version from 0.16 to 0.17 to allow for the option to disallow instance profile.
What is the impact of this change?
Better verification of worker agent installer code and behaviour.
How was this change tested?
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.