test: add test to verify that worker can shut down instance #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutongLi291
force-pushed
the
mainline
branch
from
e7b11b3 to
5ab6947
Compare
AlexTranAmz
previously approved these changes
Nov 12, 2024
YutongLi291
force-pushed
the
mainline
branch
from
5ab6947 to
c317e10
Compare
Signed-off-by: Li <[email protected]>
YutongLi291
force-pushed
the
mainline
branch
from
c317e10 to
a262e72
Compare
|
AlexTranAmz
approved these changes
Nov 12, 2024
jericht
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In an autoscaling fleet, if there are no more jobs for the fleet, after a few minutes , the auto-scaling fleet should scale down and shut down the worker instances in the fleet. The instance is shut down by the worker agent (in the case that the worker agent is allowed to shut down the instance, with the
allow_shutdownoption specified in the install)We should verify that the worker agent is able and does shut down the instance in the case that there are no more jobs available for the fleet.
What was the solution? (How)
Add a test that verifies this functionality. The test submits a job to the queue associated with the autoscaling fleet, and boots up an EC2 instance with the worker agent installed. Then after the job finished, we verify that after around 5 minutes, the instance does indeed get shut down by the worker agent as there are no more jobs available for the fleet.
What is the impact of this change?
Preventing regressions in the worker agent code that would lead to the instance shut down when scaling down a fleet to not work as expected.
How was this change tested?
Linux
source .e2e_linux_infra.sh
hatch run e2e-test
Windows
source .e2e_windows_infra.sh
hatch run e2e-test
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.