chore(deps): update requests and types-requests to 2.32 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Neilson <[email protected]>
ddneilson
force-pushed
the
update_requests_lib
branch
from
897f2e0 to
c8c3f54
Compare
|
epmog
approved these changes
Oct 29, 2024
eherozhao
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There are new versions of requests & types-requests, but the dependabot updates for these aren't passing CI.
What was the solution? (How)
Update them together.
types-requestson python 3.10 and lower requires urllib3>2 for some reason, despite requests not requiring that, so I made the types-requests update conditional.What is the impact of this change?
Updated dep
How was this change tested?
Running tests & linting.
Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.