chore(test): fixes testing race when calling Session._action_updated_impl #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-Samuel
previously approved these changes
Oct 29, 2024
ddneilson
force-pushed
the
fix_racy_session_test
branch
from
b86d511 to
72ce852
Compare
…impl Summary: Unit tests that call Session._action_updated_impl() were randomly failing because that function does some work in a Future, and the tests were not waiting for the future to complete before checking results. The future would usually complete quickly, but when it doesn't then the tests would fail. Fix the tests by exposing the inner future and waiting on it during the tests. Signed-off-by: Daniel Neilson <[email protected]>
ddneilson
force-pushed
the
fix_racy_session_test
branch
from
72ce852 to
90b55a6
Compare
|
epmog
approved these changes
Oct 29, 2024
AWS-Samuel
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Unit tests that call Session._action_updated_impl() were randomly failing
because that function does some work in a Future, and the tests were not waiting for the future to complete before checking results. The future would usually complete quickly, but when it doesn't then the tests would fail.
What was the solution? (How)
Fix the tests by exposing the inner future and waiting on it during the tests.
What is the impact of this change?
Less thrashing trying to get CI tests to pass.
How was this change tested?
Just running the unit tests a bunch of times.
Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.