test: do not retry test jobs that are expected to fail in test_job_reports_failed_session_action #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ports_failed_session_action Signed-off-by: Yutong Li <[email protected]>
|
leongdl
approved these changes
Oct 21, 2024
AlexTranAmz
approved these changes
Oct 21, 2024
YutongLi291
added a commit
to YutongLi291/deadline-cloud-worker-agent-fork
that referenced
this pull request
Oct 28, 2024
…ports_failed_session_action (aws-deadline#448) Signed-off-by: Yutong Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
test_job_reports_failed_session_actionsubmits jobs that are expected to fail. However previously we are retrying the jobs despite them expected to fail. To save time and make the test behaviour more consistent, we should no retry them.What was the solution? (How)
Give these test jobs that are expected to fail 0 retries.
What is the impact of this change?
Resources saved during testing, more consistent test behaviour.
How was this change tested?
The tests passed.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.