-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Adds telemetry client calls to worker #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
force-pushed
the
marofke/telemetry-client
branch
2 times, most recently
from
September 27, 2023 15:22
62af42e
to
8344656
Compare
marofke
changed the title
feat: Adds telemetry client calls to worker
feat!: Adds telemetry client calls to worker
Sep 27, 2023
marofke
force-pushed
the
marofke/telemetry-client
branch
from
September 29, 2023 15:29
8344656
to
7a73a46
Compare
ddneilson
approved these changes
Sep 29, 2023
crowecawcaw
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we only send telemetry when its configured to be one? I might be missing something obvious. Is opt-in/out handled in another component?
crowecawcaw
approved these changes
Sep 29, 2023
marofke
force-pushed
the
marofke/telemetry-client
branch
2 times, most recently
from
September 29, 2023 18:22
19653c4
to
27bc7ee
Compare
ddneilson
approved these changes
Sep 29, 2023
Signed-off-by: Caden Marofke <[email protected]>
marofke
force-pushed
the
marofke/telemetry-client
branch
from
September 29, 2023 18:38
27bc7ee
to
5977949
Compare
crowecawcaw
approved these changes
Sep 29, 2023
gmchale79
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Caden Marofke <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Caden Marofke <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gahyusuh
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Caden Marofke <[email protected]> Signed-off-by: Graeme McHale <[email protected]> Signed-off-by: Gahyun Suh <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Caden Marofke <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Caden Marofke <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
…ws-deadline#42) Updates the requirements on [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.3.0...v3.5.0) --- updated-dependencies: - dependency-name: pytest-xdist dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Depends on aws-deadline/deadline-cloud#60
What was the problem/requirement? (What/Why)
We want to gain insights into how our customers use our software.
What was the solution? (How)
Use the Telemetry Client introduced in the Deadline Cloud Client Library, since it's a requirement for the Worker Agent already. We introduce an installer option to opt out of telemetry collection if customers choose, which calls the client lib to set the config setting.
What is the impact of this change?
We can now collect simple startup data on Worker machines, so we know what kinds of machines typically get used for worker flows.
Further, the worker installer bash script was updated a bit to refactor the bin directory we search for installed programs, since we need to call the Deadline client lib to set the telemetry opt out option.
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
Yes, since the installer script interface changed