chore(api)!: rename jobsRunAs to jobRunAsUser #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
force-pushed
the
rename_jobs_run_as
branch
7 times, most recently
from
807291f to
075a57a
Compare
epmog
force-pushed
the
rename_jobs_run_as
branch
2 times, most recently
from
058709d to
8eda08a
Compare
ddneilson
approved these changes
Sep 26, 2023
gahyusuh
reviewed
Sep 26, 2023
Comment on lines
+192
to
+195
| # Use jobRunAsUser if it exists, otherwise jobsRunAs if it exists, otherwise None. | ||
| job_run_as_user_data = job_details_data.get( | ||
| "jobRunAsUser", job_details_data.get("jobsRunAs", None) | ||
| ) |
There was a problem hiding this comment.
Nit: should we maybe put a comment like TODO: remove this workaround once service no longer sends jobsRunAs here too?
There was a problem hiding this comment.
I'll be doing a follow-up to remove all jobsRunAs references once the service swaps (dependent on this), so I should catch this reference.
gahyusuh
approved these changes
Sep 26, 2023
Signed-off-by: Morgan Epp <[email protected]>
epmog
force-pushed
the
rename_jobs_run_as
branch
from
8eda08a to
4999474
Compare
gmchale79
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Morgan Epp <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Morgan Epp <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
gahyusuh
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Morgan Epp <[email protected]> Signed-off-by: Graeme McHale <[email protected]> Signed-off-by: Gahyun Suh <[email protected]>
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Morgan Epp <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Morgan Epp <[email protected]> Signed-off-by: Graeme McHale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The
jobsRunAsproperty in the API is being renamed in the service tojobRunAsUser, so the worker agent needs to follow suit.What was the solution? (How)
The Worker agent uses the following priority order when reading the serivce response:
jobRunAsUserif it exists in the api response, otherwisejobsRunAs, otherwiseNoneWhat is the impact of this change?
Worker Agent works with new API shape.
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
Yes.