refactor!: Rename File system options from PRELOAD/ON_DEMAND to COPIED/VIRTUAL #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pH-amz
force-pushed
the
pH-amz/filesystem-options-rename
branch
from
89823de to
31cb93c
Compare
pH-amz
force-pushed
the
pH-amz/filesystem-options-rename
branch
3 times, most recently
from
3b4c3a9 to
595e027
Compare
agerveshi
approved these changes
Oct 10, 2023
|
I would say this is a breaking change, in that it shouldn't go in with a patch release. |
…D/VIRTUAL
BREAKING CHANGES:
The changes here are a result of breaking changes in the deadline-cloud library.
- AssetLoadingMethod class is renamed to JobAttachmentsFileSystem
- PRELOAD, ON_DEMAND enum string values for AssetLoadingMethod are now called COPIED, VIRTUAL
Signed-off-by: Phanindra Bhagavatula <[email protected]>
pH-amz
force-pushed
the
pH-amz/filesystem-options-rename
branch
from
595e027 to
6faadd6
Compare
I have updated the commit message to reflect the change. |
pH-amz
changed the title
npmacl
approved these changes
Oct 10, 2023
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
…dline#40) Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.6.0...v1.7.0) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
AssetLoadingMethod variable and its options were renamed in deadline-cloud library. This change is a downstream effect of that.
What was the solution? (How)
Rename AssetLoadingMethod and its options to new names
What is the impact of this change?
This is a downstream change due to changes in deadline-cloud
How was this change tested?
By running unit tests
Was this change documented?
N/A
Is this a breaking change?
Yes