test: Add test for CANCELED session actions and environment actions logs and make FAILED action test cross OS #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <[email protected]>
Signed-off-by: Yutong Li <[email protected]>
Signed-off-by: Yutong Li <[email protected]>
|
benl-2023
approved these changes
Jul 29, 2024
AlexTranAmz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have a core feature of worker agent in which the session actions should be CANCELED properly, when a job is set to CANCELED for its taskRunStatus. There's also another core feature of Worker Agent in which the outputs of the environments should be able to be found in the job logs.
We should keep these parts of the Worker Agentcode quality high for the future and prevent and possible regressions through dependencies or code.
What was the solution? (How)
Add a test that tests that each of
envEnter,taskRun, andenvExitare CANCELED properly when job is updated to be CANCELED taskRunStatus.Also added a test that tests that environment enter logs are correctly written.
Also refactored an existing test so that it runs on both Linux and Windows. No logical change.
What is the impact of this change?
Better testing and code quality for worker agent code.
How was this change tested?
hatch run linux-e2e-testhatch run cross-os-e2e-testwith windows and linux fleets specified.Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.