feat: fail jobs configured to run as worker agent user on Windows #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
approved these changes
Mar 21, 2024
| @@ -708,6 +708,22 @@ def _create_new_sessions( | |||
| # Requires some updates to the code below | |||
| try: | |||
| job_details = job_entities.job_details() | |||
|
|
|||
| # For Windows the WA runs as Administrator so fail jobs that were configured to runAs - WORKER_AGENT_USER as that would provide Admin privileges to the job | |||
| if ( | |||
There was a problem hiding this comment.
I expect that we may end up relaxing this to Administrator + Running-as-a-service in future, but this is the agreed upon behavior right now.
jusiskin
added
enhancement
jusiskin
approved these changes
Mar 21, 2024
jusiskin
changed the title
ddneilson
force-pushed
the
sakshie/fail_jobs_run_as_admin
branch
from
da63815 to
95cf7b5
Compare
Signed-off-by: Sakshi Sakshi <[email protected]>
ddneilson
force-pushed
the
sakshie/fail_jobs_run_as_admin
branch
from
95cf7b5 to
d9a9cbf
Compare
sakshie95
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Sakshi Sakshi <[email protected]>
Merged
baxeaz
pushed a commit
that referenced
this pull request
Mar 23, 2024
Signed-off-by: Sakshi Sakshi <[email protected]> Signed-off-by: Brian Axelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have determined that the Worker Agent needs Administrator privileges in Windows.
This poses risk that any queues configured to run jobs as the agent user would then have administrator privileges.
What was the solution? (How)
If the agent is running as an administrator and receives a job and the
BatchGetJobEntityAPI request for the jobDetails returns ajobRunAsUser→runAsisWORKER_AGENT_USER, then we should fail the job with a message explaining that the queue and fleet are setup in an insecure configuration and the job would run with administrator privileges.What is the impact of this change?
Better security
How was this change tested?
Added unit tests
Was this change documented?
N/A
Is this a breaking change?
N/A