fix(session): fix instantiation of of WindowsFileSystemPermissionSettings to not use os_group
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmchale79
approved these changes
Mar 14, 2024
…os_group Signed-off-by: Gahyun Suh <[email protected]>
gahyusuh
force-pushed
the
gahyusuh/remove_windows_os_group
branch
from
8953297 to
4e69707
Compare
marofke
approved these changes
Mar 14, 2024
|
The PR #213 already covered my changes. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The Job Attachment has been updated so that it does not use group names in permissions settings for Windows file system. For details, please see: aws-deadline/deadline-cloud#196. Specifically, the
os_groupfield in theWindowsFileSystemPermissionSettingsclass can now be effectively ignored.What was the solution? (How)
Do not pass
os_groupwhen instantiateWindowsFileSystemPermissionSettingsclassWhat is the impact of this change?
N/A
How was this change tested?
Ran unit tests
Was this change documented?
Yes.
Is this a breaking change?
No.