fix: Improve logging on failures to fetch secret #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
previously approved these changes
Feb 28, 2024
gmchale79
force-pushed
the
gmchale79/improved_logging
branch
from
c483733 to
346c508
Compare
matta-aws
previously approved these changes
Feb 28, 2024
jusiskin
force-pushed
the
jusiskin/windows_service
branch
4 times, most recently
from
1274c9f to
38ba32f
Compare
jusiskin
force-pushed
the
jusiskin/windows_service
branch
6 times, most recently
from
d4400fc to
26dd138
Compare
ddneilson
dismissed stale reviews from matta-aws and jericht
The base branch was changed.
gmchale79
force-pushed
the
gmchale79/improved_logging
branch
2 times, most recently
from
b6ad06d to
030ed41
Compare
ddneilson
approved these changes
Mar 20, 2024
jericht
approved these changes
Mar 21, 2024
Signed-off-by: Graeme McHale <[email protected]>
ddneilson
force-pushed
the
gmchale79/improved_logging
branch
from
030ed41 to
3d50323
Compare
Merged
baxeaz
pushed a commit
that referenced
this pull request
Mar 23, 2024
Signed-off-by: Graeme McHale <[email protected]> Signed-off-by: Brian Axelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The logging around
get_secret_valuepreviously gave the customer no indication as to what might be wrong.What was the solution? (How)
Making sure
AccessDeniedExceptionis not swallowed and customers are given some information on how to resolve failures.What is the impact of this change?
See above.
How was this change tested?
Unit tests.
Was this change documented?
NA.
Is this a breaking change?
No.