Skip to content

Commit

Permalink
ci: add missing dollar sign in github workflow .yml files
Browse files Browse the repository at this point in the history
Signed-off-by: Josh Usiskin <[email protected]>
  • Loading branch information
jusiskin committed Dec 17, 2024
1 parent 6b60cf2 commit 0f8c049
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 34 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Code Quality

on:
pull_request:
branches: [ mainline, feature_windows ]
branches: [ mainline ]
workflow_call:
inputs:
branch:
Expand All @@ -11,7 +11,7 @@ on:

jobs:
UnitTest:
name: Python
name: Unit Tests - {{ matrix.os }}, python {{ matrix.python-version }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
Expand All @@ -20,10 +20,11 @@ jobs:
with:
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}

IntegrationTests:
name: Integration Tests - {{ matrix.os }}, python {{ matrix.python-version }}
name: Integration Tests - ${{ matrix.os }}, python ${{ matrix.python-version }}
needs: UnitTest
runs-on: {{ matrix.os }}
runs-on: ${{ matrix.os }}
permissions:
contents: read
strategy:
Expand All @@ -38,4 +39,4 @@ jobs:
pip install --upgrade hatch
- name: Run Integration Tests
run: hatch run integ-test
run: hatch run integ-test
4 changes: 2 additions & 2 deletions .github/workflows/mainline_e2e_canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:

jobs:
IntegrationTests:
name: Integration Tests - {{ matrix.os }}, python {{ matrix.python-version }}
runs-on: {{ matrix.os }}
name: Integration Tests - ${{ matrix.os }}, python ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
permissions:
contents: read
strategy:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mainline_e2e_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:

jobs:
IntegrationTests:
name: Integration Tests - {{ matrix.os }}, python {{ matrix.python-version }}
runs-on: {{ matrix.os }}
name: Integration Tests - ${{ matrix.os }}, python ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
permissions:
contents: read
strategy:
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/release_bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,6 @@ jobs:
with:
branch: mainline

IntegrationTests:
needs: UnitTests
name: Integration Tests - {{ matrix.os }}, python {{ matrix.python-version }}
runs-on: {{ matrix.os }}
permissions:
id-token: write
contents: read
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
python-version: ['3.9', '3.10', '3.11']
env:
PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v4

- name: Install Hatch
run: |
pip install --upgrade hatch
- name: Run Integration Tests
run: hatch run integ-test

LinuxE2ETests:
needs: UnitTests
name: Linux E2E Test
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_e2e_canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:

jobs:
IntegrationTests:
name: Integration Tests - {{ matrix.os }}, python {{ matrix.python-version }}
runs-on: {{ matrix.os }}
name: Integration Tests - ${{ matrix.os }}, python ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
permissions:
contents: read
strategy:
Expand Down

0 comments on commit 0f8c049

Please sign in to comment.