fix: FleetAPI compatibility for WorkerRequirements #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
reviewed
Mar 23, 2024
lucaseck
previously approved these changes
Mar 24, 2024
Signed-off-by: Trevor Blanchard <[email protected]>
lucaseck
approved these changes
Mar 24, 2024
epmog
approved these changes
Mar 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
WorkerRequirements changed to WorkerCapabilities in the CreateFleet API
What was the solution? (How)
Making the API calls backwards compatible.
What is the impact of this change?
Create fleet now works
How was this change tested?
Was this change documented?
Is this a breaking change?
No