Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fixes for build system #18

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: minor fixes for build system #18

merged 1 commit into from
Dec 6, 2023

Conversation

jericht
Copy link
Contributor

@jericht jericht commented Sep 20, 2023 •
edited
Loading

What was the problem/requirement? (What/Why)

  • __init__.py had some values in __all__ that were not imported. Also, we should import all pytest fixtures.
  • The IAM role for bootstrapping the worker is missing permissions for aws s3 cp AWS CLI command in some environments
  • Configuring the Worker agent requires AWS_DEFAULT_REGION to be defined in some environments

What was the solution? (How)

Fixes for all points above

What is the impact of this change?

Fixes are applied

How was this change tested?

Unit tests pass

Was this change documented?

No

Is this a breaking change?

No

@jericht jericht force-pushed the jericht/fixes branch 5 times, most recently from 5499fe0 to 6e32a29 Compare September 20, 2023 20:17
@jericht jericht marked this pull request as ready for review September 20, 2023 20:20
@jericht jericht requested a review from a team as a code owner September 20, 2023 20:20
@jericht jericht requested a review from ttblanchard September 20, 2023 20:20
@jericht
fix: minor fixes for build system
46d4106 
Signed-off-by: Jericho Tolentino <[email protected]>
@jericht jericht marked this pull request as draft December 6, 2023 00:36
@jericht jericht marked this pull request as ready for review December 6, 2023 21:21
@jericht
Copy link
Contributor Author

jericht commented Dec 6, 2023

Verified this is working again, safe to merge

@jericht jericht merged commit c398961 into mainline Dec 6, 2023
12 checks passed
@jericht jericht deleted the jericht/fixes branch December 6, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moorec-aws moorec-aws moorec-aws approved these changes

@ddneilson ddneilson ddneilson approved these changes

@ttblanchard ttblanchard Awaiting requested review from ttblanchard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jericht @ddneilson @moorec-aws