fix!: delete workers from non-autoscaling fleets #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
force-pushed
the
moorec/delete_worker
branch
from
71b04e1 to
6905655
Compare
jusiskin
requested changes
Jul 3, 2024
moorec-aws
force-pushed
the
moorec/delete_worker
branch
from
6905655 to
95cf528
Compare
jusiskin
requested changes
Jul 4, 2024
Signed-off-by: Charles Moore <[email protected]>
moorec-aws
force-pushed
the
moorec/delete_worker
branch
from
95cf528 to
2616f06
Compare
jusiskin
approved these changes
Jul 4, 2024
ttblanchard
approved these changes
Jul 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
non-autoscaling fleets workers are not deleted automatically from fleets. This causes errors when tests are run more than the amount of workers a fleet is allowed to launch.
What was the solution? (How)
What is the impact of this change?
Allow the tests to run more than twice.
How was this change tested?
Tested using the Worker Agent tests.
Was this change documented?
No
Is this a breaking change?
Yes, changes the behaviour of how workers are stopped. We now pass a fleet object to the worker configuration instead of an id.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.